- Status Fix Pending
- Task Type Bug Report
- Category Papyrus
- Operating System All
- Severity Medium
- Priority Medium
- Reported Version Fallout 4: Vanilla
- Due in Version Undecided
FS#22271 - WorkshopParentScript - corrections to the UFO4P 2.0 modifications related to #21895
Ticket #21895 is about delaying the workshop reset while an attack is running (and the player is present at that workshop at this time). While the procedure works as intended, the handling turned out to be somewhat inefficient in cases where the player leaves a workshop during the attack:
(1) the player leaves during an attack and returns while the attack is still running: in that case, a superfluous second reset may be started (but both will run after the attack is over). This can be avoided by adding a check to the OnLocationChange event.
(2) the player leaves during an attack and does not return before the attack is over: in that case, the attack is resolved off screen. WorkshopAttackScript will still make an independent call to the UFO4P_ResolveAttack function on WorkshopParentScript, but this may occur with some delay then. As a result, it will take more time until the attack data are cleared (note: until this happens, daily updates on any workshops are suspended because the scripts assume that the attack is still running). This situation can be significantly improved by letting the ResolveAttack function clear the data.